Add configuration to control existence of "go to <type>" on hover #1590
+29
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@yangdanny97 @kinto0 this is the pr for issue 1581 |
kinto0
changed the title
kinto0
requested changes
Nov 17, 2025
Contributor
kinto0
left a comment
kinto0
left a comment
There was a problem hiding this comment.
Looks great! thanks for working on this. a few suggestions:
- looks like CI is red for formatting, could you run the formatter?
- would you be able to update ide.mdx and lsp/readme.md with a description of the new setting?
- would you be able to add this config value to lsp/package.json so clients like vscode show it in the vscode settings?
Contributor
Author
|
thanks @kinto0 for the feedback I have made the required changes could you please review it and let me know if anything else needs to be done |
…ake flag visible in vs code and did formatting
kinto0
approved these changes
Nov 18, 2025
yangdanny97
approved these changes
Nov 18, 2025
Contributor
yangdanny97
left a comment
yangdanny97
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1581
Adds configuration option to control whether hover tooltips display "Go to definition" links.
Following pattern from #1421.
Configuration
{ "python.analysis.showHoverGoToLinks": false }Default:
true(backward compatible)Changes
workspace.rs: Add config field to LspAnalysisConfigserver.rs: Read config and pass to hover implementationhover.rs: Conditionally show links based on configplayground.rs: Pass default value (true)hover.rs(test): Update test5 files changed, +18 insertions, -4 deletions
Testing
✅ Tested with config enabled/disabled
✅ Backward compatible (defaults to true)
✅ All existing tests pass